storage: Use timeout for boltdb database opening #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyfyrchik
force-pushed
the
fix-dump
branch
2 times, most recently
from
af47c17
to
3e6621d
Compare
To dump the DB, the service must be stopped. If this is not the case `dump` command just hangs without any output, which _may_ be unexpected from the ops POV. Introduce a 1 second timeous, which is more than enough, given that bbolt retries doing flock() every 50ms. Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
roman-khimov
approved these changes
Oct 6, 2023
AnnaShaleva
approved these changes
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
==========================================
- Coverage 84.84% 84.84% -0.01%
==========================================
Files 330 330
Lines 44332 44337 +5
==========================================
+ Hits 37615 37617 +2
- Misses 5204 5206 +2
- Partials 1513 1514 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To dump the DB, the service must be stopped. If this is not the case
dumpcommand just hangs without any output.This may be unexpected from the ops POV (hello, @532910).
Solution
Introduce timeout for bbolt db open. I have decided not to put it in the configuration, because 5 seconds is more than enough, given that flock retry is 50 milliseconds
https://github.com/etcd-io/bbolt/blob/db45d0d6b1f6d173baad00019fdc7c58ad0ab002/db.go#L19
https://github.com/etcd-io/bbolt/blob/db45d0d6b1f6d173baad00019fdc7c58ad0ab002/db.go#L222
Do you think this is worth having in the configuration (like I dump and then stop the service and expect dump to work for such a usecase)?