Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: upgrade coverage uploading action #3153

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

AnnaShaleva
Copy link
Member

Currently it's failing, but no token is required for public repos:

[2023-10-10T10:35:11.917Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Currently it's failing, but no token is required for public repos:
```
[2023-10-10T10:35:11.917Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
```

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva added the test Unit tests label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #3153 (bb9b836) into master (eeb439f) will increase coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   84.91%   84.92%   +0.01%     
==========================================
  Files         330      330              
  Lines       44337    44337              
==========================================
+ Hits        37648    37654       +6     
+ Misses       5172     5168       -4     
+ Partials     1517     1515       -2     
Files Coverage Δ
pkg/compiler/codegen.go 92.05% <100.00%> (ø)
pkg/core/storage/boltdb_store.go 78.76% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnnaShaleva
Copy link
Member Author

Well, at least Coverage job isn't failing on this branch. Maybe workflow version is not the real problem (we'll see later), but it's not bad to have it updated.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review October 10, 2023 11:08
@AnnaShaleva AnnaShaleva added this to the v0.103.0 milestone Oct 10, 2023
@roman-khimov roman-khimov merged commit fce98a0 into master Oct 10, 2023
14 of 18 checks passed
@roman-khimov roman-khimov deleted the fix-codecov branch October 10, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants