Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: always provide start parameter for findstorage RPC #3166

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

AnnaShaleva
Copy link
Member

Close #3137.

Close #3137.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #3166 (1841d81) into master (ef2bc7c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   85.41%   85.43%   +0.02%     
==========================================
  Files         323      323              
  Lines       43635    43641       +6     
==========================================
+ Hits        37270    37285      +15     
+ Misses       4895     4888       -7     
+ Partials     1470     1468       -2     
Files Coverage Δ
pkg/rpcclient/rpc.go 86.20% <100.00%> (+0.13%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit cb0ef2d into master Oct 18, 2023
30 of 33 checks passed
@roman-khimov roman-khimov deleted the find-storage-param branch October 18, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindStorageByHash can't be used with C# nodes when omitting start param
2 participants