interop: add contract storage limits #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of NeoGo interop package may have a demand to use these limits for custom purposes, it would be nice to have them as constants. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
BTW, I'm not sure that it's good to have neo-go dependency in interops. And I'm afraid that we won't be able to compile it, that's the case. |
|
Argh! Modules. I forgot about modules. Yeah, that might be a problem. |
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3232 +/- ##
==========================================
+ Coverage 85.30% 85.38% +0.07%
==========================================
Files 327 327
Lines 44081 44081
==========================================
+ Hits 37603 37638 +35
+ Misses 4994 4957 -37
- Partials 1484 1486 +2 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of NeoGo interop package may have a demand to use these limits for custom purposes, it would be nice to have them as constants.
@roman-khimov, do we need it? If so, then I'll create a test and update deps. Draft until that.