unwrap: implement Exception type for better exception handling #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3438 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 331 331
Lines 38432 38434 +2
=======================================
+ Hits 33106 33110 +4
+ Misses 3800 3799 -1
+ Partials 1526 1525 -1 ☔ View full report in Codecov by Sentry. |
Fix #3130. "Exception" is used for name since it's shorter and that's the name used in JSON. "VMFault" was also considered as well as "FaultException" (which mirrors result.Invoke). Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
unwrap-fault-exception
branch
from
04e25b5
to
f4731ea
Compare
AnnaShaleva
reviewed
May 16, 2024
carpawell
approved these changes
May 16, 2024
AnnaShaleva
approved these changes
May 16, 2024
AliceInHunterland
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3130. "Exception" is used for name since it's shorter and that's the name used in JSON. "VMFault" was also considered as well as "FaultException" (which mirrors result.Invoke).