Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust minor SAST warnings #3455

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Adjust minor SAST warnings #3455

merged 2 commits into from
Jun 5, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3419

@AliceInHunterland AliceInHunterland changed the title Sast Adjust minor SAST warnings May 21, 2024
@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.12%. Comparing base (cd525a1) to head (41109f4).

Files Patch % Lines
pkg/services/oracle/request.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
- Coverage   86.14%   86.12%   -0.02%     
==========================================
  Files         331      331              
  Lines       38476    38476              
==========================================
- Hits        33145    33139       -6     
- Misses       3802     3808       +6     
  Partials     1529     1529

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnnaShaleva
AnnaShaleva reviewed Jun 3, 2024
View reviewed changes
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/services/oracle/request.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Jun 5, 2024
View reviewed changes
pkg/core/blockchain.go Outdated Show resolved Hide resolved
@AliceInHunterland
core: adjust prevHeader nil check
5c408f7 
prevHeader is never nil.

Refs #3419

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland
oracle: add length check o.MainCfg.NeoFS.Nodes
41109f4 
Prevent the risk of a division by zero error when accessing the
`o.MainCfg.NeoFS.Nodes[index]` array.

Close #3419

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AnnaShaleva AnnaShaleva merged commit 3c471f0 into master Jun 5, 2024
19 of 21 checks passed
@AnnaShaleva AnnaShaleva deleted the sast branch June 5, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor SAST warnings
3 participants
@AliceInHunterland @roman-khimov @AnnaShaleva