cli: add embedded node config #3477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3477 +/- ##
==========================================
- Coverage 86.11% 86.11% -0.01%
==========================================
Files 331 331
Lines 38541 38556 +15
==========================================
+ Hits 33190 33201 +11
- Misses 3819 3824 +5
+ Partials 1532 1531 -1 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
a147a60
to
768d91e
Compare
AnnaShaleva
reviewed
Jun 5, 2024
Default config for VM CLI is privnet + InMemory DB. |
AliceInHunterland
force-pushed
the
vm-default-config
branch
2 times, most recently
from
bdee5e4
to
319faeb
Compare
AnnaShaleva
reviewed
Jun 5, 2024
AliceInHunterland
force-pushed
the
vm-default-config
branch
4 times, most recently
from
22ad6a6
to
bf02042
Compare
AliceInHunterland
force-pushed
the
vm-default-config
branch
4 times, most recently
from
6128144
to
950f35d
Compare
AnnaShaleva
reviewed
Jun 7, 2024
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
950f35d
to
0e9f525
Compare
AliceInHunterland
force-pushed
the
vm-default-config
branch
3 times, most recently
from
0e3a68d
to
edbb172
Compare
AnnaShaleva
reviewed
Jun 26, 2024
|
Linter and tests are failing. |
AnnaShaleva
changed the title
AnnaShaleva
reviewed
Jun 26, 2024
AliceInHunterland
force-pushed
the
vm-default-config
branch
3 times, most recently
from
de919b6
to
cbc1314
Compare
config/config_embed.go
Outdated
| // UnitTestnetConfig is the unit testnet configuration. | ||
| // | ||
| //go:embed protocol.unit_testnet.yml | ||
| var UnitTestnetConfig []byte |
There was a problem hiding this comment.
Removed, but we have it as a hidden flag in CLI.
cli.BoolFlag{Name: "unittest", Hidden: true},
AnnaShaleva
reviewed
Jun 27, 2024
config/config_embed.go
Outdated
| // UnitTestnetConfig is the unit testnet configuration. | ||
| // | ||
| //go:embed protocol.unit_testnet.yml | ||
| var UnitTestnetConfig []byte |
AliceInHunterland
force-pushed
the
vm-default-config
branch
2 times, most recently
from
f96259e
to
23df797
Compare
AnnaShaleva
reviewed
Jun 27, 2024
AnnaShaleva
reviewed
Jun 27, 2024
AnnaShaleva
reviewed
Jun 27, 2024
AliceInHunterland
force-pushed
the
vm-default-config
branch
2 times, most recently
from
eb571fb
to
257ee53
Compare
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
257ee53
to
4ca2127
Compare
|
Please, fix the commit message: |
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
4ca2127
to
58256de
Compare
AnnaShaleva
reviewed
Jun 28, 2024
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
58256de
to
c9c3bea
Compare
If `config-path` is not passed, default configs are used according to the set network. In VM CLI the default privnet config with InMemory db is used. Close #3450 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
vm-default-config
branch
from
c9c3bea
to
43ee1b2
Compare
AnnaShaleva
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Please, add "Close #3459" to the commit/PR message.
Otherwise LGTM.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
config-pathis not provided then the default config is used. Ifconfig-pathis provided but the directory does not contain a configuration file for the desired passed network and this directory isn't our default./config, the error "config '%s' doesn't exist" will be received.Close #3450