Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: implement getcontractstate RPC #675

Merged
merged 8 commits into from
Feb 18, 2020
Merged

Conversation

AnnaShaleva
Copy link
Member

closes #342

@AnnaShaleva AnnaShaleva added feature Completely new functionality rpc RPC server and client labels Feb 15, 2020
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #675 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   65.09%   65.16%   +0.06%     
==========================================
  Files         125      125              
  Lines       10695    10715      +20     
==========================================
+ Hits         6962     6982      +20     
  Misses       3454     3454              
  Partials      279      279
Impacted Files Coverage Δ
pkg/rpc/server.go 82% <100%> (+0.95%) ⬆️
pkg/rpc/errors.go 61.9% <100%> (+4.01%) ⬆️
pkg/rpc/prometheus.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681891...2b9e63c. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.73.0 milestone Feb 16, 2020
@fyrchik
Copy link
Contributor

fyrchik commented Feb 17, 2020

typo in the commit message of f664b09 : should be ... getrawtransaction ...

pkg/core/helper_test.go Outdated Show resolved Hide resolved
pkg/core/helper_test.go Outdated Show resolved Hide resolved
pkg/core/helper_test.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the feature/getContractState branch 4 times, most recently from 8d355a3 to 2235cd7 Compare February 17, 2020 12:50
@AnnaShaleva AnnaShaleva force-pushed the feature/getContractState branch 3 times, most recently from 51d4345 to 28c6ac5 Compare February 17, 2020 16:25
pkg/core/helper_test.go Outdated Show resolved Hide resolved
pkg/core/helper_test.go Outdated Show resolved Hide resolved
Fixed getassetstate method: it should return error with code -100 when
asset with specified id is not found (as in c# node).
Changed returncode of getrowtransaction method in case when transaction
with specified hash does not exists. Now it returns error with code -100
instead of -32602 (as in c# node)
Simplified reversing of scriptHash
Marked getcontractstate method in rpc docs as "implemented"
newRPCTestChain function generates test chain "testblocks.acc" for RPC
tests
@roman-khimov roman-khimov merged commit 86cf309 into master Feb 18, 2020
@roman-khimov roman-khimov deleted the feature/getContractState branch February 18, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC: implement getcontractstate
4 participants