-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: implement getcontractstate RPC #675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 65.09% 65.16% +0.06%
==========================================
Files 125 125
Lines 10695 10715 +20
==========================================
+ Hits 6962 6982 +20
Misses 3454 3454
Partials 279 279
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Feb 16, 2020
typo in the commit message of f664b09 : should be |
fyrchik
reviewed
Feb 17, 2020
golangcibot
reviewed
Feb 17, 2020
8d355a3
to
2235cd7
Compare
golangcibot
reviewed
Feb 17, 2020
51d4345
to
28c6ac5
Compare
golangcibot
reviewed
Feb 17, 2020
a317f52
to
82aa423
Compare
Fixed getassetstate method: it should return error with code -100 when asset with specified id is not found (as in c# node).
Changed returncode of getrowtransaction method in case when transaction with specified hash does not exists. Now it returns error with code -100 instead of -32602 (as in c# node)
Simplified reversing of scriptHash
Marked getcontractstate method in rpc docs as "implemented"
newRPCTestChain function generates test chain "testblocks.acc" for RPC tests
b462b44
to
2b9e63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #342