Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: provide message type and view inside RecoveryMessage #679

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 18, 2020

PrepareRequest inside RecoveryMessage should contain both
message type and view.

PrepareRequest inside RecoveryMessage should contain both
message type and view.
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #679 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   65.23%   65.22%   -0.01%     
==========================================
  Files         125      125              
  Lines       10737    10743       +6     
==========================================
+ Hits         7004     7007       +3     
- Misses       3454     3457       +3     
  Partials      279      279
Impacted Files Coverage Δ
pkg/consensus/recovery_message.go 84.33% <66.66%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f5570...ee8514d. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.73.0 milestone Feb 18, 2020
@roman-khimov roman-khimov merged commit b5ec94b into master Feb 18, 2020
@roman-khimov roman-khimov deleted the fix/recovery_message branch February 18, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consensus dBFT consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants