Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: implement getblocksysfee RPC #684

Merged
merged 1 commit into from
Feb 21, 2020
Merged

rpc: implement getblocksysfee RPC #684

merged 1 commit into from
Feb 21, 2020

Conversation

AnnaShaleva
Copy link
Member

closes #341

@AnnaShaleva AnnaShaleva added feature Completely new functionality rpc RPC server and client labels Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #684 into master will increase coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   65.73%   65.77%   +0.04%     
==========================================
  Files         128      128              
  Lines       10827    10846      +19     
==========================================
+ Hits         7117     7134      +17     
- Misses       3432     3433       +1     
- Partials      278      279       +1
Impacted Files Coverage Δ
pkg/rpc/server/prometheus.go 100% <100%> (ø) ⬆️
pkg/rpc/server/server.go 83.91% <88.88%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f87cd...76a0a6e. Read the comment docs.

@AnnaShaleva AnnaShaleva self-assigned this Feb 19, 2020
fyrchik
fyrchik suggested changes Feb 19, 2020
View reviewed changes
pkg/rpc/server.go Outdated Show resolved Hide resolved
pkg/rpc/server.go Outdated Show resolved Hide resolved
pkg/rpc/server_test.go Outdated Show resolved Hide resolved
@fyrchik
Copy link
Contributor

fyrchik commented Feb 19, 2020

I'd merge this 2 commits into 1, there is no need to split tests from implementation.

@AnnaShaleva AnnaShaleva force-pushed the feature/getblocksysfee branch 3 times, most recently from 26b06b9 to e68aa2e Compare February 19, 2020 11:38
@roman-khimov
Copy link
Member

This one needs to be updated after #676.

@AnnaShaleva AnnaShaleva force-pushed the feature/getblocksysfee branch 2 times, most recently from 600a80d to 320e1da Compare February 21, 2020 15:39
@roman-khimov roman-khimov merged commit 5d4dfbf into master Feb 21, 2020
@roman-khimov roman-khimov deleted the feature/getblocksysfee branch February 21, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees

@AnnaShaleva AnnaShaleva

Labels
feature Completely new functionality rpc RPC server and client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC: implement getblocksysfee
3 participants
@AnnaShaleva @fyrchik @roman-khimov