cli: implement transfer from multisig accounts #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 64.03% 64.52% +0.48%
==========================================
Files 132 134 +2
Lines 11695 11869 +174
==========================================
+ Hits 7489 7658 +169
+ Misses 3913 3901 -12
- Partials 293 310 +17
Continue to review full report at Codecov.
|
roman-khimov
reviewed
Mar 3, 2020
roman-khimov
reviewed
Mar 3, 2020
roman-khimov
reviewed
Mar 3, 2020
roman-khimov
reviewed
Mar 3, 2020
roman-khimov
reviewed
Mar 3, 2020
roman-khimov
reviewed
Mar 4, 2020
| ) | ||
|
|
||
| // ParameterContext represents smartcontract parameter's context. | ||
| type ParameterContext struct { |
There was a problem hiding this comment.
This type name bugs me, context.ParameterContext seems wrong, but context.Parameter is also questionable because of smartcontract.Parameter.
roman-khimov
reviewed
Mar 4, 2020
roman-khimov
reviewed
Mar 4, 2020
roman-khimov
reviewed
Mar 4, 2020
Address is marshaled in base58 and needs to be decoded accordingly.
Both verification and invocation scripts need to be unmarshaled from hex. Also fix failing RPC tests: block contains non-pointer `transaction.Witness` field and (*Witness).MarshalJSON method is not called.
It contains no information so it doesn't matter anyway.
When creating witness for a multisig contract, it is needed to extract the order of public keys from it.
It is needed to be able to create Contracts from the outside.
When transferring assets from multisig accounts, it is useful to export tx into a file, so that other participants can sign it too.
After all signatures were accumulated it should be possible to extract Witness for the verifiable item.
Implement ability to sign transactions with multisig address. This should be done in several steps: 1. Create TX with `wallet transfer --out <file>` 2. Sign TX with `wallet multisign sign --in <file> --out <file2>`. 3. Repeat 2 for every party. Input file contains transaction with possibly incomplete set of the signatures. Output file will contain the same tx with updated signature set. When --rpc flag is provided, result transaction is sent via `sendrawtransaction`.
roman-khimov
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as follows:
neo-go wallet transfer --rpc http://127.0.0.1:30333 --path wallet1.json \ --from AZ81H31DMWzbSnFDLFkzh9vHwaDLayV7fU --amount 1 \ --asset NEO --to AK2nJJpJr6o664CWJKi1QRXjqeic2zRp8y --out tx1.json neo-go wallet multisig sign --path wallet2.json --in tx1.json --out tx2.json neo-go wallet multisig sign --path wallet3.json --in tx2.json --out tx3.json \ --rpc htp://127.0.0.1:30333