Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC docs, implement client-side getblock and getrawtransaction #715

Merged
merged 4 commits into from
Mar 4, 2020

Conversation

roman-khimov
Copy link
Member

Problem

Stale documentation, missing client methods.

Solution

Update docs, implement some methods.

transaction.Transaction currently has issues with JSON marshaling/unmarshaling (like #585), so getrawtransaction behavior it's not entirely correct at the moment.

And drop doc.go from server package as it duplicates docs/rpc.md and has no
value of its own (TODO list is managed with GitHub issues, really). Also, RPC
server is not really expected to be used by non-neo-go packages (contrary to
the client).
Add missing methods, move example into something that can be compiled (and fix
it along the way).
They differ in input and output types (and data), thus four methods are
added.
@roman-khimov roman-khimov added the rpc RPC server and client label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #715 into master will decrease coverage by 1.74%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   65.78%   64.03%   -1.75%     
==========================================
  Files         129      132       +3     
  Lines       11386    11696     +310     
==========================================
  Hits         7490     7490              
- Misses       3603     3913     +310     
  Partials      293      293
Impacted Files Coverage Δ
pkg/rpc/client/rpc.go 0% <0%> (ø)
pkg/rpc/client/client.go 0% <0%> (ø)
pkg/rpc/client/neoscan.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7480ad1...a9d8c9e. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 4, 2020
@roman-khimov roman-khimov merged commit 8141d49 into master Mar 4, 2020
@roman-khimov roman-khimov deleted the rpc-doc-and-client branch March 4, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants