Update RPC docs, implement client-side getblock and getrawtransaction #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And drop doc.go from server package as it duplicates docs/rpc.md and has no value of its own (TODO list is managed with GitHub issues, really). Also, RPC server is not really expected to be used by non-neo-go packages (contrary to the client).
Add missing methods, move example into something that can be compiled (and fix it along the way).
They differ in input and output types (and data), thus four methods are added.
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 65.78% 64.03% -1.75%
==========================================
Files 129 132 +3
Lines 11386 11696 +310
==========================================
Hits 7490 7490
- Misses 3603 3913 +310
Partials 293 293
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stale documentation, missing client methods.
Solution
Update docs, implement some methods.
transaction.Transactioncurrently has issues with JSON marshaling/unmarshaling (like #585), sogetrawtransactionbehavior it's not entirely correct at the moment.