Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: implement getblockheader RPC #722

Merged
merged 1 commit into from
Mar 5, 2020
Merged

rpc: implement getblockheader RPC #722

merged 1 commit into from
Mar 5, 2020

Conversation

AnnaShaleva
Copy link
Member

closes #711

@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited
Loading

Codecov Report

Merging #722 into master will decrease coverage by 0.04%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   64.03%   63.99%   -0.05%     
==========================================
  Files         132      133       +1     
  Lines       11696    11741      +45     
==========================================
+ Hits         7490     7514      +24     
- Misses       3913     3932      +19     
- Partials      293      295       +2
Impacted Files Coverage Δ
pkg/rpc/response/result/block_header.go 0% <0%> (ø)
pkg/rpc/server/prometheus.go 100% <100%> (ø) ⬆️
pkg/rpc/server/server.go 84.7% <85.18%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8141d49...42e2aff. Read the comment docs.

@AnnaShaleva AnnaShaleva force-pushed the feature/getblockheader branch 2 times, most recently from 674edd9 to 76aa939 Compare March 5, 2020 09:57
roman-khimov
roman-khimov requested changes Mar 5, 2020
View reviewed changes
pkg/rpc/response/result/block_header.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the feature/getblockheader branch 3 times, most recently from 0ee132e to fb8e369 Compare March 5, 2020 10:36
@roman-khimov roman-khimov added the rpc RPC server and client label Mar 5, 2020
@roman-khimov roman-khimov merged commit b273f31 into master Mar 5, 2020
@roman-khimov roman-khimov deleted the feature/getblockheader branch March 5, 2020 14:18
@roman-khimov roman-khimov mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
rpc RPC server and client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement getblockheader RPC method
2 participants
@AnnaShaleva @roman-khimov