cli: implement NEP5-related commands #728
Conversation
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=========================================
- Coverage 66.68% 66.3% -0.38%
=========================================
Files 136 138 +2
Lines 12269 12381 +112
=========================================
+ Hits 8181 8209 +28
- Misses 3692 3775 +83
- Partials 396 397 +1
Continue to review full report at Codecov.
|
pkg/wallet/token.go
Outdated
| func (t *Token) MarshalJSON() ([]byte, error) { | ||
| m := &tokenAux{ | ||
| Name: t.Name, | ||
| Hash: t.Hash.Reverse(), // address should be marshaled in LE but here it is marshaled in LE |
There was a problem hiding this comment.
tokenAux will be marshalled with the default JSON marshaler, which uses BE.
Token address is used as LE everywhere so it is better to store it the same way.
| @@ -28,7 +28,7 @@ type Wallet struct { | |||
|
|
|||
| // Extra metadata can be used for storing arbitrary data. | |||
| // This field can be empty. | |||
| Extra interface{} `json:"extra"` | |||
| Extra Extra `json:"extra"` | |||
There was a problem hiding this comment.
I'm not sure about this. It obviously is more effective storing these values, but at the same time it makes us update the wallet for every NEP5 token and may affect interoperability.
There was a problem hiding this comment.
It is fully compliant with NEP-6 standard.
It's size is used in NEP5TransferLog so we need to be sure it reflects reality.
When working with NEP5 contracts we frequently need to parse fixed-point decimals with arbitrary precision.
It can be useful to receive all NEP5 token info at once.
To work with NEP5 tokens, one need to save some info e.g. token Name. This way we will not make additional RPC just to get Decimals.
getclaimable RPC expects address as a 1-st argument.
Closes #709 .