compiler: clean up stack on branch statements #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 66.68% 66.73% +0.05%
==========================================
Files 136 136
Lines 12269 12299 +30
==========================================
+ Hits 8181 8208 +27
- Misses 3692 3695 +3
Partials 396 396
Continue to review full report at Codecov.
|
pkg/compiler/codegen.go
Outdated
| @@ -834,6 +858,32 @@ func (c *codegen) Visit(node ast.Node) ast.Visitor { | |||
| return c | |||
| } | |||
|
|
|||
| func (c *codegen) pushLabel(name string, size int) { | |||
There was a problem hiding this comment.
Can we name these in some other fashion? We have newLabel, setLabel, generateLabel, getLabelOffset already and if you're to add pushLabel, dropLabel that work with a different structure and have some different semantics, I think it'll be a mess. Something around branching and stack?
There was a problem hiding this comment.
Renamed to (push/drop)StackLabel.
When `return` or `break` statement is encountered inside a for/range/switch statement, top stack items can be auxilliary. They need to be cleaned up before returning from the function.
roman-khimov
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
returnorbreakstatement is encountered insidea for/range/switch statement, top stack items can be auxilliary.
They need to be cleaned up before returning from the function.
Related to #683 .
The only unfixed test RN is a function call used as a statement.