Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc/server] fix getblock verbose response #734

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

im-kulikov
Copy link
Contributor

Problem

  • Nonce should not trim leading zeros
  • NextConsensus should returns address (uint160 -> base58)

Solution

see changes

- Nonce should not trim leading zeros
- NextConsensus should returns address (uint160 -> base58)
@im-kulikov im-kulikov added bug Something isn't working rpc RPC server and client labels Mar 6, 2020
@im-kulikov im-kulikov self-assigned this Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #734 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   66.77%   66.77%           
=======================================
  Files         136      136           
  Lines       12213    12213           
=======================================
  Hits         8155     8155           
  Misses       3664     3664           
  Partials      394      394           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8ff55...b34ac22. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 6, 2020
@roman-khimov roman-khimov merged commit 1b7b9e7 into master Mar 6, 2020
@roman-khimov roman-khimov deleted the fix/getblock-response branch March 6, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants