core: store NEP5 balances separately from account #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
- Coverage 65.86% 65.82% -0.05%
==========================================
Files 138 138
Lines 12461 12543 +82
==========================================
+ Hits 8208 8256 +48
- Misses 3854 3887 +33
- Partials 399 400 +1
Continue to review full report at Codecov.
|
Use existing functions to invoke smartcontract's method instead of constructing ad-hoc script.
There is no need to take and unmarshal an account structure only to get it's NEP5 balances.
There was a problem hiding this comment.
One thing I think still is missing here is NEP5Balances and NEP5Transfers caching in the cachedDao. Just take a look at typical blocks like these:
https://neoscan.io/block/233db5a99fd0bb893fd9bb4abee4806ade8a99c64cb8ee3aad9ca2338f8a6e4d
https://neoscan.io/block/5216166
https://neoscan.io/block/4997999
https://neoscan.io/block/4717987
I see at lot of cache hits there.
This is an append-only log which is read only during some RPCs. It is rather slow to get it from base every time we need to append to it. This commit stores all NEP5Transfers in batches, so that only a last batch needs to be unmarshaled during block processing.
roman-khimov
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track NEP5-related things separately from account.