Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: marshal Asset hash in LE in getnep5balances RPC #751

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 12, 2020

Asset hash should be returned without leading 0x in little-endian.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #751 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #751      +/-   ##
=========================================
- Coverage   64.78%   64.7%   -0.09%     
=========================================
  Files         139     140       +1     
  Lines       12734   12751      +17     
=========================================
  Hits         8250    8250              
- Misses       4083    4100      +17     
  Partials      401     401
Impacted Files Coverage Δ
pkg/rpc/response/result/nep5.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb9e1d...66727ab. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 16, 2020
@roman-khimov roman-khimov merged commit 800e3fe into master Mar 16, 2020
@roman-khimov roman-khimov deleted the fix/transfer branch March 16, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants