-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: implement wallet remove-account
#757
Conversation
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 64.84% 64.89% +0.05%
==========================================
Files 141 141
Lines 12779 12793 +14
==========================================
+ Hits 8286 8302 +16
+ Misses 4091 4089 -2
Partials 402 402
Continue to review full report at Codecov.
|
// Probably there are better ways to ask. | ||
// See https://www.dartmouth.edu/consent/communication/howdo.html | ||
// Examples of Questions to Ask | ||
fmt.Print("Are you sure? [y/N]: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure (this will irrevocably destroy the associated private key)? [y/N]:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase in brackets needs to be printed before this function is invoked (it is used in both remove-account
and nep5 remove
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to ask for nep5 removal? It can easily be undone, unlike destroying an account.
Creating accounts is done frequently so it makes sense to have lesser name for this command. `create` -> `init` `create-account` -> `create`
Make it possible to remove unneeded accounts from wallet.
Sometimes we need to use custom verification script, e.g. for contracts where funds needs to become accessible only after a certain amount of time.
Also add tests for Add/RemoveToken
Remove unused tokens from the wallet.
Closes #26. Seems like everything is implemented :)