cli: implement wallet remove-account
#757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 64.84% 64.89% +0.05%
==========================================
Files 141 141
Lines 12779 12793 +14
==========================================
+ Hits 8286 8302 +16
+ Misses 4091 4089 -2
Partials 402 402
Continue to review full report at Codecov.
|
| // Probably there are better ways to ask. | ||
| // See https://www.dartmouth.edu/consent/communication/howdo.html | ||
| // Examples of Questions to Ask | ||
| fmt.Print("Are you sure? [y/N]: ") |
There was a problem hiding this comment.
Are you sure (this will irrevocably destroy the associated private key)? [y/N]:
There was a problem hiding this comment.
The phrase in brackets needs to be printed before this function is invoked (it is used in both remove-account and nep5 remove).
There was a problem hiding this comment.
Do we need to ask for nep5 removal? It can easily be undone, unlike destroying an account.
roman-khimov
requested changes
Mar 16, 2020
Creating accounts is done frequently so it makes sense to have lesser name for this command. `create` -> `init` `create-account` -> `create`
Make it possible to remove unneeded accounts from wallet.
Sometimes we need to use custom verification script, e.g. for contracts where funds needs to become accessible only after a certain amount of time.
Also add tests for Add/RemoveToken
Remove unused tokens from the wallet.
roman-khimov
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26. Seems like everything is implemented :)