Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix contract's state migration and don't swallow errors #760

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

roman-khimov
Copy link
Member

Fixes difference in state changes at mainnet's block 2442790 because contract
migration in b4eb2dc35226e6520ee4e09a56197dff91547b50a7f57edc82930fc18c75dffc
doesn't actually transfer the storage state, it only deletes the old one.

And add an error check just in case.

Fixes difference in state changes at mainnet's block 2442790 because contract
migration in b4eb2dc35226e6520ee4e09a56197dff91547b50a7f57edc82930fc18c75dffc
doesn't actually transfer the storage state, it only deletes the old one.

And add an error check just in case.
@roman-khimov roman-khimov added bug Something isn't working smartcontract Smart contracts and associated package labels Mar 16, 2020
@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ba1c3bf). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #760   +/-   ##
=========================================
  Coverage          ?   64.77%           
=========================================
  Files             ?      139           
  Lines             ?    12736           
  Branches          ?        0           
=========================================
  Hits              ?     8250           
  Misses            ?     4085           
  Partials          ?      401
Impacted Files Coverage Δ
pkg/core/interop_neo.go 59.03% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1c3bf...e6e8761. Read the comment docs.

@roman-khimov roman-khimov merged commit cff6e22 into master Mar 16, 2020
@roman-khimov roman-khimov deleted the fix-contract-storage-migration branch March 16, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smartcontract Smart contracts and associated package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants