rpc: add testing to RPC client package #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
from
024ae63
to
af89635
Compare
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=========================================
+ Coverage 64.54% 66.94% +2.4%
=========================================
Files 141 141
Lines 12980 13034 +54
=========================================
+ Hits 8378 8726 +348
+ Misses 4200 3898 -302
- Partials 402 410 +8
Continue to review full report at Codecov.
|
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
2 times, most recently
from
219b185
to
e381358
Compare
golangcibot
reviewed
Mar 18, 2020
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
3 times, most recently
from
f9c0d36
to
68d2a39
Compare
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
2 times, most recently
from
87816fc
to
58c3dac
Compare
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
6 times, most recently
from
ffead2c
to
4c18262
Compare
Problem: wrong json marshalling of `nextconsensus` field of result.Header Solution: change field type from util.uint160 to address string
problem: `script` field of result.ContractState is marshalled as []byte solution: add marshaller for result.ContractState
Problem: wrong json field name of result.NEP5Balances.Balances (see for details: https://github.com/neo-project/neo-modules/blob/master-2.x/RpcNep5Tracker/RpcNep5Tracker.cs#L295) Solution: rename field from `balances` to `balance` to be consistent with C# client
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
from
4c18262
to
8e601a7
Compare
roman-khimov
requested changes
Mar 24, 2020
Problem: wrong `PublicKey` field json marshalling of result.Validator Solution: add marshaller to publickey (crypto)
closes #716 NOTE: RPC client tests contain `serverResponse` json data fetched from examples published in official C# JSON-RPC API v2.10.3 reference (see https://docs.neo.org/docs/en-us/reference/rpc/latest-version/api.html)
AnnaShaleva
force-pushed
the
feature/rpc_client_tests
branch
from
8e601a7
to
6998c50
Compare
roman-khimov
approved these changes
Mar 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #716
Minor bug fixes for json marshalling of the following fields:
result.Header.NextConsensusresult.ContractState.Scriptresult.NEP5Balances.Balancesresult.Validator.PublicKey