Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue tx verification #765

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Fix issue tx verification #765

merged 3 commits into from
Mar 17, 2020

Conversation

roman-khimov
Copy link
Member

Problem

Missing some checks for Issue transactions.

Solution

Add them.

@roman-khimov roman-khimov added this to the v0.74.0 milestone Mar 16, 2020
@roman-khimov roman-khimov added the bug Something isn't working label Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #765 into master will increase coverage by 0.37%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   64.45%   64.82%   +0.37%     
==========================================
  Files         141      139       -2     
  Lines       12881    12664     -217     
==========================================
- Hits         8302     8209      -93     
+ Misses       4177     4056     -121     
+ Partials      402      399       -3
Impacted Files Coverage Δ
pkg/core/blockchain.go 44.44% <0%> (+2.43%) ⬆️
pkg/core/mempool/mem_pool.go 97.2% <100%> (+0.11%) ⬆️
pkg/core/state/account.go 58.75% <0%> (-25.54%) ⬇️
pkg/wallet/wallet.go 76.11% <0%> (-6.6%) ⬇️
pkg/rpc/request/txBuilder.go 50.67% <0%> (-1.41%) ⬇️
pkg/core/dao.go 68.68% <0%> (-1.15%) ⬇️
pkg/rpc/server/server.go 84.71% <0%> (-0.12%) ⬇️
pkg/rpc/client/nep5.go 0% <0%> (ø) ⬆️
pkg/rpc/response/result/unclaimed.go 0% <0%> (ø) ⬆️
pkg/core/storage/store.go 37.5% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e5cdd...ec76a0b. Read the comment docs.

It shouldn't try to issue more tokens than there is available.
Technically they could conflict for available asset amount, but as they're
very rare (and even can be considered obsolete) we can simplify this check.
@roman-khimov roman-khimov merged commit 93236e0 into master Mar 17, 2020
@roman-khimov roman-khimov deleted the fix-issue-tx-verification branch March 17, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants