vm: make map serialization more compatible with C# #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# pushes value and key to the stack of non-serialized items, so key gets serialized first followed by value. Fixes #806. Notice though that neither IDictionary in C#, nor map in Go have elements ordered, so we can easily get a difference in KV pairs order and it would be impossible to fix.
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 141 141
Lines 12963 12963
=======================================
Hits 8654 8654
Misses 3899 3899
Partials 410 410
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# pushes value and key to the stack of non-serialized items, so key gets
serialized first followed by value. Fixes #806.
Notice though that neither IDictionary in C#, nor map in Go have elements
ordered, so we can easily get a difference in KV pairs order and it would be
impossible to fix.