Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: support implicit type in function arguments #935

Merged
merged 1 commit into from
May 6, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 6, 2020

Go supports declaring multiple arguments of the same type without
duplicating type name. Now we support this too.

Closes #933.

Go supports declaring multiple arguments of the same type without
duplicating type name. Now we support this too.
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #935 into master-2.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x     #935      +/-   ##
==============================================
- Coverage       67.98%   67.97%   -0.02%     
==============================================
  Files             143      143              
  Lines           13569    13569              
==============================================
- Hits             9225     9223       -2     
- Misses           3914     3916       +2     
  Partials          430      430              
Impacted Files Coverage Δ
pkg/compiler/codegen.go 88.26% <100.00%> (ø)
pkg/rpc/client/wsclient.go 76.31% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e097e86...37813f1. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Porting to master is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler Go smart contract compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slices with implicit type definition pass incorrectly to the function
2 participants