Fix pickitem and vm cli 2.x #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was setting a (wrong) breakpoint and couldn't then break out of it.
bafdb91 change was wrong (probably brought from neo-vm 3.0 at the state at which it existed back then), neo-vm 2.x doesn't allow PICKITEM for arbitrary types.
Codecov Report
@@ Coverage Diff @@
## master-2.x #967 +/- ##
===========================================
Coverage 68.21% 68.21%
===========================================
Files 144 144
Lines 14185 14181 -4
===========================================
- Hits 9676 9674 -2
+ Misses 4057 4055 -2
Partials 452 452
Continue to review full report at Codecov.
|
fyrchik
approved these changes
May 21, 2020
fyrchik
approved these changes
May 21, 2020
| return nil, err | ||
| } | ||
| item = vm.NewBigIntegerItem(val) | ||
| case stringType: |
There was a problem hiding this comment.
mabe some sort of hex will also be useful
There was a problem hiding this comment.
There is a lot of room for improvement there, add an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#965.
Solution
Fix it and improve vm cli a bit.