protocol: move magic exchange to version payload #970
Merged
+46
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 64.49% 64.51% +0.01%
==========================================
Files 200 200
Lines 16841 16842 +1
==========================================
+ Hits 10862 10865 +3
+ Misses 5418 5416 -2
Partials 561 561
Continue to review full report at Codecov.
|
roman-khimov
requested changes
May 21, 2020
pkg/network/server.go
Outdated
| @@ -160,7 +160,7 @@ func NewServer(config ServerConfig, chain blockchainer.Blockchainer, log *zap.Lo | |||
| // MkMsg creates a new message based on the server configured network and given | |||
| // parameters. | |||
| func (s *Server) MkMsg(cmd CommandType, p payload.Payload) *Message { | |||
| return NewMessage(s.Net, cmd, p) | |||
| return NewMessage(cmd, p) | |||
There was a problem hiding this comment.
This actually makes s.MkMsg() useless, we can drop it now.
AnnaShaleva
force-pushed
the
neo3/protocol/magic_exchange
branch
from
9c4810b
to
64a2fb6
Compare
roman-khimov
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #889