Add key size checks 2.x #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one type of keys is allowed here.
DecodeBinary works with streams, so it can't do that, but DecodeBytes can and should. Also fix unmarshalled binary buffer that this check exposed.
Codecov Report
@@ Coverage Diff @@
## master-2.x #971 +/- ##
==============================================
- Coverage 68.00% 67.99% -0.02%
==============================================
Files 145 145
Lines 14305 14312 +7
==============================================
+ Hits 9728 9731 +3
- Misses 4117 4121 +4
Partials 460 460
Continue to review full report at Codecov.
|
fyrchik
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#968.
Solution
Fix it.