Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make GetUnspentCoins interop return array, fix #978. #979

Merged
merged 2 commits into from
May 22, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 22, 2020

Fix #978.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #979 into master-2.x will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x     #979      +/-   ##
==============================================
- Coverage       68.00%   67.97%   -0.04%     
==============================================
  Files             145      145              
  Lines           14313    14320       +7     
==============================================
  Hits             9734     9734              
- Misses           4119     4126       +7     
  Partials          460      460              
Impacted Files Coverage Δ
pkg/core/interop_neo.go 57.75% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9b2ae...eeeb05f. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please fix the issue number (it's 978, not 938)
  2. Our UnspentCoin structure differs from the one from C# (it kinda merges spent and unspent coins from it), you need to filter States by State to get the same result (unspents only).
  3. We need to get back to a587274 then and re-add this function as GetUnspentCoins(t Transaction) []output.Output.

pkg/core/interop_neo.go Outdated Show resolved Hide resolved
pkg/core/interop_neo.go Show resolved Hide resolved
@roman-khimov roman-khimov merged commit 3675502 into master-2.x May 22, 2020
@roman-khimov roman-khimov deleted the fix/state branch May 22, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage changes mismatch @mainnet's block 4188122
2 participants