New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check stringers for every well-known header value #147

Closed

alexvanin opened this issue Sep 17, 2020 · 1 comment

Assignees

Contributor

alexvanin commented Sep 17, 2020

Well-known object headers, such as ObjectID, OwnerID have related string constants, because neofs-api define header names in extended ACL filter and object search request as string type.

These filters also define values as string type, so we should check all stringer implementation of OwnerID, ObjectID and others related types in v2 and SDK.

The text was updated successfully, but these errors were encountered:

Contributor Author

alexvanin commented Oct 13, 2020

We've decided to make stringers and parsers for owner.ID, object.ID and container.ID structures. All these values should be presented as base58 encoded strings.

alexvanin mentioned this issue

Use base58 encoders in search and EACL queries nspcc-dev/neofs-node#88

Closed

im-kulikov self-assigned this

im-kulikov pushed a commit that referenced this issue


          [#147] Add constant error type

c3a3f10

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around container package

787fd75

- implement Stringer interface and Parse method for container.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

4b27584

- implement Stringer interface and Parse method for object.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

871ad91

- implement Stringer interface and Parse method for object.Address
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

Add NEO3WalletSize as constant value.

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

7e52e66

- implement Stringer interface and Parse method for owner.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around container package

08a41c2

- implement Stringer interface and Parse method for container.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

fb2d222

- implement Stringer interface and Parse method for object.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

1d2f4a0

- implement Stringer interface and Parse method for object.Address
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

Add NEO3WalletSize as constant value.

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

70c1251

- implement Stringer interface and Parse method for owner.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Add constant error type

80d85ba

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around container package

- implement Stringer interface and Parse method for container.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

b6888e8

- implement Stringer interface and Parse method for object.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

4e1f817

- implement Stringer interface and Parse method for object.Address
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

2cf2a8a

Add NEO3WalletSize as constant value.

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

3618e9e

- implement Stringer interface and Parse method for owner.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around object package

723f7ac

- implement Stringer interface and Parse method for object.Address
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

2ff00cd

Add NEO3WalletSize as constant value.

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

926fab8

- implement Stringer interface and Parse method for owner.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

im-kulikov pushed a commit that referenced this issue


          [#147] Work around owner package

e2e7fd5

- implement Stringer interface and Parse method for owner.ID
- increase test coverage

closes #147

Signed-off-by: Evgeniy Kulikov <kim@nspcc.ru>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment