Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errors in JSON converters #185

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

alexvanin
Copy link
Contributor

There is a proposal from @im-kulikov to return errors in JSON converters because these converters work with raw []byte and error nil check is more clear for go-developers in case of data marshaling.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #185 into master will increase coverage by 0.20%.
The diff coverage is 72.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   40.96%   41.16%   +0.20%     
==========================================
  Files          74       74              
  Lines        8364     8349      -15     
==========================================
+ Hits         3426     3437      +11     
+ Misses       4466     4453      -13     
+ Partials      472      459      -13     
Impacted Files Coverage Δ
v2/acl/json.go 66.66% <66.66%> (+28.20%) ⬆️
v2/container/json.go 80.00% <80.00%> (+41.53%) ⬆️
v2/netmap/json.go 80.00% <80.00%> (+41.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac38d13...e1ff339. Read the comment docs.

Copy link
Contributor

@im-kulikov im-kulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexvanin alexvanin merged commit 352e99d into nspcc-dev:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants