Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop neofs-crypto dependency #443

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Drop neofs-crypto dependency #443

merged 2 commits into from
Feb 26, 2024

Conversation

roman-khimov
Copy link
Member

Nothing bad in random one here.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Yeah, makes code a bit more hairy here, but it can be improved eventually.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (cfca09b) 63.79% compared to head (d358418) 63.44%.

Files Patch % Lines
util/signature/options.go 11.11% 46 Missing and 2 partials ⚠️
util/signature/data.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   63.79%   63.44%   -0.35%     
==========================================
  Files          76       76              
  Lines        9526     9573      +47     
==========================================
- Hits         6077     6074       -3     
- Misses       2722     2776      +54     
+ Partials      727      723       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 5fe4f10 into master Feb 26, 2024
5 of 7 checks passed
@roman-khimov roman-khimov deleted the drop-neofs-crypto branch February 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants