Return clear dial errors #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 51.65% 51.70% +0.05%
==========================================
Files 159 159
Lines 19840 19841 +1
==========================================
+ Hits 10248 10259 +11
+ Misses 8820 8807 -13
- Partials 772 775 +3 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 28, 2024
Fix came from nspcc-dev/neofs-api-go#445 for the problem described in nspcc-dev/neofs-node#2561. Фlso now any irreparable errors like invalid address will be returned immediately, not upon reaching the deadline. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 28, 2024
Fix came from nspcc-dev/neofs-api-go#445 for the problem described in nspcc-dev/neofs-node#2561. Фlso now any irreparable errors (like invalid net address or TLS handshake) will be returned immediately, not upon reaching the deadline. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
client-ret-conn-error
branch
2 times, most recently
from
9392e16
to
2844227
Compare
Inspired by nspcc-dev/neofs-node#2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Since 2b89b7e, RPC client used `grpc.WithBlock` option to dial the server. This option make dialer to return either `nil` or `context.DeadlineExceeded` errors, with any connection error resulting in the latter. In particular, TLS handshake failures were shadowed by deadline error. Now `WithReturnConnectionError` option is used instead: * it still blocks similar to `WithBlock`; * it adds connection failure to the deadline error. As a result, TLS unit test passes now. This should fix the problem originally posted in nspcc-dev/neofs-node#2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, RPC client unconditionally blocked by context passed into `WithContext` (e.g. for 15s). In particular, it definitely stuck on non-temporary error encounter. An example of such errors could be an incorrect network address or connection refusal. Now client instantly fails with any irreparable error in which it is pointless to wait for a change in the connection state. This is achieved with `grpcstd.FailOnNonTempDialError(true)` option. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
client-ret-conn-error
branch
from
2844227
to
e99341f
Compare
roman-khimov
approved these changes
Feb 28, 2024
carpawell
approved these changes
Feb 28, 2024
yes it is. Unit test emulates problem behavior. Explained in the commit |
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 28, 2024
Fix came from nspcc-dev/neofs-api-go#445 for the problem described in nspcc-dev/neofs-node#2561. Фlso now any irreparable errors (like invalid net address or TLS handshake) will be returned immediately, not upon reaching the deadline. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Feb 28, 2024
Fix came from nspcc-dev/neofs-api-go#445 for the problem described in nspcc-dev/neofs-node#2561. Also now any irreparable errors (like invalid net address or TLS handshake) will be returned immediately, not upon reaching the deadline. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.