Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Epoch and Version setters on ResponseMetaHeader #55

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #55 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #55      +/-   ##
==========================================
+ Coverage     7.84%   7.89%   +0.04%     
==========================================
  Files           44      44              
  Lines        17812   17814       +2     
==========================================
+ Hits          1398    1406       +8     
+ Misses       16203   16197       -6     
  Partials       211     211
Impacted Files Coverage Δ
service/meta.go 85.71% <100%> (+1.09%) ⬆️
service/meta.pb.go 7.37% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a98dff...a21e42e. Read the comment docs.

Copy link
Contributor

@alexvanin alexvanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cthulhu-rider cthulhu-rider merged commit fb0c724 into develop Feb 14, 2020
@cthulhu-rider cthulhu-rider deleted the object-response-set-epoch branch February 14, 2020 10:11
cthulhu-rider pushed a commit that referenced this pull request Feb 25, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request Feb 25, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants