Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Disable homomorphic hashing for container #217

Merged
merged 1 commit into from
May 30, 2022
Merged

Feat/Disable homomorphic hashing for container #217

merged 1 commit into from
May 30, 2022

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented Apr 25, 2022

@carpawell carpawell added the enhancement Improving existing functionality label Apr 25, 2022
@carpawell carpawell self-assigned this Apr 25, 2022
@carpawell carpawell changed the title Feat/Disable homomorhic hashing for container Feat/Disable homomorphic hashing for container Apr 25, 2022
@carpawell carpawell marked this pull request as ready for review April 29, 2022 18:55
@@ -65,4 +65,7 @@ message Container {

// Placement policy for the object inside the container
neo.fs.v2.netmap.PlacementPolicy placement_policy = 6 [json_name = "placementPolicy"];

// Disabling homomorphic hashing calculation for container's objects.
bool homomorphic_hashing_disabled = 7;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use container attributes instead of adding one more field?

@carpawell carpawell marked this pull request as draft May 4, 2022 10:51
@carpawell carpawell marked this pull request as ready for review May 27, 2022 11:47
@carpawell carpawell requested a review from realloc May 27, 2022 11:47
@carpawell
Copy link
Member Author

Did not generate doc since it contains too many unrelated changes after language fixes. Consider regeneration in pre-release preparation.

cthulhu-rider
cthulhu-rider previously approved these changes May 27, 2022
fyrchik
fyrchik previously approved these changes May 28, 2022
Copy link
Contributor

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the issue number in commit message is still XXX.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@realloc realloc merged commit 64ab86a into nspcc-dev:master May 30, 2022
@carpawell carpawell deleted the feat/disable-homomorhic-hashing-for-container branch May 30, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants