Fix/Clarify lock object usage #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realloc
previously approved these changes
May 27, 2022
fyrchik
previously approved these changes
May 30, 2022
fyrchik
previously approved these changes
May 30, 2022
lock/types.proto
Outdated
| @@ -9,7 +9,8 @@ import "refs/types.proto"; | |||
|
|
|||
| // Lock objects protects a list of objects from being deleted. The lifetime of a | |||
| // lock object is limited similar to regular objects in | |||
| // `__NEOFS__EXPIRATION_EPOCH` attribute. | |||
| // `__NEOFS__EXPIRATION_EPOCH` attribute. Lock object MUST have expiration epoch. | |||
| // It is impossible to delete lock object via ObjectService.Delete RPC call. | |||
There was a problem hiding this comment.
to delete A lock object, sorry, missed that before.
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
realloc
approved these changes
May 31, 2022
Decided not to wait for some tests? |
Well, seems like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nspcc-dev/neofs-node#1227 (comment) for details.
Think it could wait until the whole implementation is ready and testing to prevent any breaking changes in the future (in fact I think that PR is already a breaking change).