-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check both node and alphabet signature in netmap contract #154
Comments
I found interesting thing when I was testing nspcc-dev/neo-go#2150 with reverted #155 Storage node prepares We must consider this, simple revert is not enough. |
This reverts commit a9503b5
However Alphabet nodes create new There are several options how we can handle it: 1. Split
|
After nspcc-dev/neofs-contract#154 alphabet nodes should call `Register` method for approval of the notifications spawned by `AddPeer` method. Change `NewFromMorph` constructor of netmap morph client: it now makes client to invoke `register` method of Netmap contract instead of `addPeer` inside `AddPeer` method if `AsAlphabet` option is provided. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
After nspcc-dev/neofs-contract#154 alphabet nodes should call `Register` method for approval of the notifications spawned by `AddPeer` method. Change `NewFromMorph` constructor of netmap morph client: it now makes client to invoke `register` method of Netmap contract instead of `addPeer` inside `AddPeer` method if `AsAlphabet` option is provided. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
After nspcc-dev/neofs-contract#154 alphabet nodes should call `Register` method for approval of the notary notifications spawned by `AddPeer` method. Change `AddPeerNotaryEvent` constant to `register`. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
After nspcc-dev/neofs-contract#154 alphabet nodes should call `Register` method for approval of the notary notifications spawned by `AddPeer` method. Call `register` method for peer approval in Netmap processor. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
After nspcc-dev/neofs-contract#154 alphabet nodes should call `Register` method for approval of the notary notifications spawned by `AddPeer` method. Call `register` method for peer approval in Netmap processor. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Wait until nspcc-dev/neo-go#2150 is resolved.
The text was updated successfully, but these errors were encountered: