netmap: split UpdateState method for notary-enabled environment
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is better naming scheme for understanding, I am afraid it will break compatibility with older storage nodes as they continue to invoke |
carpawell
reviewed
Mar 14, 2022
… environment Split methods similar to `AddPeer`/`Register` pair from b104a2c . Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Similar to `UpdateState`/`UpdateStateIR` pair. Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
alexvanin
approved these changes
Mar 17, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
`Register` was renamed to `AddPeerIR` for consistency with `UpdateState` changes in nspcc-dev/neofs-contract#227 This is protocol breaking change for notary enabled environment. Luckily, there is no notary enabled environments anywhere except of neofs-dev-env, so we can do such thing. We should avoid such changes in the future, though. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #225 .
Split methods similar to
AddPeer/Registerpair from b104a2c .The one with
Peerin name should be called by a storage node similar toAddPeer/Register.Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru