Makefile: generate RPC bindings #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also need to bump minimum required go version up to 1.18. |
roman-khimov
reviewed
Jun 5, 2023
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
2 times, most recently
from
d38082f
to
29ca934
Compare
|
@roman-khimov, do we need binding files to be stored in this repo or it's OK to add them to .gitignore? |
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
from
29ca934
to
1c0408f
Compare
roman-khimov
reviewed
Jun 9, 2023
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
2 times, most recently
from
3141c6b
to
066c6b1
Compare
| $(NEOGO) contract compile -i $(2)$(1) -c $(if $(2),$(2),$(1)/)config.yml -m $(2)$(1)/config.json -o $(2)$(1)/$(1)_contract.nef | ||
| $(NEOGO) contract compile -i $(2)$(1) -c $(if $(2),$(2),$(1)/)config.yml -m $(2)$(1)/config.json -o $(2)$(1)/$(1)_contract.nef --bindings $(2)$(1)/bindings_config.yml | ||
| mkdir -p rpc/$(1) | ||
| $(NEOGO) contract generate-rpcwrapper -o rpc/$(1)/rpcbinding.go -m $(2)$(1)/config.json --config $(2)$(1)/bindings_config.yml |
There was a problem hiding this comment.
This, btw, should be handled by the Makefile. Makefile is not a shell script, it's all about targets, dependencies and the way they're produced.
There was a problem hiding this comment.
That's the only question I wasn't able to fix. Could you, please, review one more time and point out how to create a proper make target depending on all these rpc/... bindings?
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
12 times, most recently
from
1f0c100
to
0442927
Compare
Extend contract configuration files with additional types information where needed. Add resulting RPC bindings to the repo. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
There's no more *.manifest.json files, we store manifest in the config.json file (don't know why). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
from
0442927
to
3846313
Compare
First of all, RPC bindings must be compiled. After that, if there are some changes in the bindings for the current NeoGo version, then these changes have to be committed. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Use afa4530c7d739d08df7865440dbe66f55f7e558b commit (the current master). It allows to omit hash parameter for RPC bindings and make them reusable for a set of different networks. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
generate-rpc-bindings
branch
from
3846313
to
10a8769
Compare
roman-khimov
approved these changes
Aug 2, 2023
|
@smallhive, can you try importing packages from this branch? |
Working on it |
cthulhu-rider
approved these changes
Aug 3, 2023
carpawell
reviewed
Aug 3, 2023
| @@ -7,7 +7,7 @@ export GOBIN ?= $(shell pwd)/bin | |||
| export CGO_ENABLED=0 | |||
| NEOGO ?= $(GOBIN)/cli | |||
| VERSION ?= $(shell git describe --tags --dirty --match "v*" --always --abbrev=8 2>/dev/null || cat VERSION 2>/dev/null || echo "develop") | |||
| NEOGOORIGMOD = github.com/nspcc-dev/neo-go | |||
| NEOGOORIGMOD = github.com/nspcc-dev/neo-go@v0.101.5-0.20230802075307-afa4530c7d73 | |||
There was a problem hiding this comment.
@AnnaShaleva, since that is a temporary use, do we need an issue for that?
There was a problem hiding this comment.
There will be an issue to upgrade to 0.102.0 anyway. Can be created now, doesn't matter much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for 0.102.0 release of neo-go to convert from draft.UPD: we'll use fresh NeoGo master to build SCs and RPC bindings.