Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request X-Header no longer supported #1194

Closed
cthulhu-rider opened this issue Feb 25, 2022 · 1 comment · Fixed by #1209
Closed

Request X-Header no longer supported #1194

cthulhu-rider opened this issue Feb 25, 2022 · 1 comment · Fixed by #1209
Assignees
@cthulhu-rider
Labels
bug Something isn't working
Milestone
v0.28.0

Comments

@cthulhu-rider
Copy link
Contributor

After pre-release changes of NeoFS SDK Client call parameters no longer support request X-Headers. Some components were tied to it. These headers are a detail of the particular version of the NeoFS API protocol, so Client, by design, should not support them in generic calls.

We can configure Client with version-dependent pre-call hook, which is going to be called only within a certain version. If communication version is different, hook isn't called.
@cthulhu-rider cthulhu-rider added bug Something isn't working triage labels Feb 25, 2022
@cthulhu-rider
Copy link
Contributor Author

Decided to support headers in all future protocol versions (so far only in words). So we can support them in prm structures.

@cthulhu-rider cthulhu-rider self-assigned this Mar 3, 2022
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Mar 3, 2022
[nspcc-dev#1194] client: Support request X-headers
0591c52 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider mentioned this issue Mar 3, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@aprasolova
[nspcc-dev#1194] client: Support request X-headers
4ed627b 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider added a commit that referenced this issue Feb 26, 2024
@cthulhu-rider
object: Stop supporting NETMAP_* X-headers
fe6d8fb 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
448ac71 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Feb 28, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
a4de38b 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Feb 29, 2024
@cthulhu-rider
object: Stop supporting __NEOFS__NETMAP* X-headers
5ad331c 
They are not supported since
nspcc-dev/neofs-api#279. Now storage nodes
process the current epoch only.

Refs #1194.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

Upgrade NeoFS SDK Go cthulhu-rider/neofs-node
2 participants
@alexvanin @cthulhu-rider