Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC should have some reaction on container removal event #1663

Closed
carpawell opened this issue Aug 5, 2022 · 1 comment
Closed

GC should have some reaction on container removal event #1663

carpawell opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working I2 Regular impact neofs-storage Storage node application issues S2 Regular significance U2 Seriously planned
Milestone

Comments

@carpawell
Copy link
Member

carpawell commented Aug 5, 2022

Node is able to track container removal but currently, it does nothing.

It could:

  1. Mark object of just removed container for removal;
  2. Change its behavior (do not replicate objs, do not send estimations for that cnr, etc)
  3. Mark container as removed in the Metabase to prevent operation with the objects that are still stored but technically do not exist anymore
  4. ...

/cc @realloc

@carpawell carpawell added discussion Open discussion of some problem triage neofs-storage Storage node application issues labels Aug 5, 2022
@roman-khimov roman-khimov added this to the v0.38.0 milestone Apr 22, 2023
@roman-khimov roman-khimov modified the milestones: v0.38.0, v0.39.0 Aug 4, 2023
@roman-khimov
Copy link
Member

Looks like we have some cases like this on mainnet (slightly modified tool from #2491):

2023/08/15 09:00:37 read container 5bq36EJ27VWTyzWtyVaeXMBr339TSex5v3uJLwnjMM3w: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 2pWrCbvejFqLy1Z3jEYLyACVX6ZdhLudnFjt2Ct5HT1B: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 2pWrCbvejFqLy1Z3jEYLyACVX6ZdhLudnFjt2Ct5HT1B: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 2pkfDULFobUXxVw4NVvqNjbmUwZHKv7dwU32W8SatrLr: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 5bq36EJ27VWTyzWtyVaeXMBr339TSex5v3uJLwnjMM3w: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 5bq36EJ27VWTyzWtyVaeXMBr339TSex5v3uJLwnjMM3w: status: code = 3072 message = container not found
2023/08/15 09:00:37 read container 5qj8tUtmARpJNtfzX1PfF4u8vugqAdM29x3Sv31Qdr5X: status: code = 3072 message = container not found
2023/08/15 09:00:38 read container EShohP7bvDmVoTXo8Xg2MXcXgi5yw1zjSqrSrhEz17rv: status: code = 3072 message = container not found
2023/08/15 09:00:38 read container EShohP7bvDmVoTXo8Xg2MXcXgi5yw1zjSqrSrhEz17rv: status: code = 3072 message = container not found
2023/08/15 09:00:38 read container 5qj8tUtmARpJNtfzX1PfF4u8vugqAdM29x3Sv31Qdr5X: status: code = 3072 message = container not found
2023/08/15 09:00:38 read container 8y8BmXckTq2GikSQ6x5MKyj7jEb6uGRm2JmsWheWi9Fp: status: code = 3072 message = container not found

@carpawell carpawell self-assigned this Nov 2, 2023
@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.40.0 Nov 28, 2023
carpawell added a commit that referenced this issue Dec 1, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Dec 1, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Dec 4, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Dec 4, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Dec 5, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit that referenced this issue Dec 15, 2023
Closes #1663.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov added U2 Seriously planned S2 Regular significance I2 Regular impact bug Something isn't working and removed discussion Open discussion of some problem labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I2 Regular impact neofs-storage Storage node application issues S2 Regular significance U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants