Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generic tests for storage components #1686

Closed
fyrchik opened this issue Aug 15, 2022 · 0 comments · Fixed by #1718
Closed

Implement generic tests for storage components #1686

fyrchik opened this issue Aug 15, 2022 · 0 comments · Fixed by #1718

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Aug 15, 2022

We need 2 kinds of tests:

  1. For storage components (blobstor, metabase, writecache, pilorama, shard as a whole):

    1. All operations are idempodent, i.e. SetMode, Close, Open do not panic if called twice and do nothing on the second call.
    2. Check all possible mode transitions (SetMode between all pair op modes, the latest SetMode should be checked for correctness, Open in RW/RO mode, following some SetMode).
    3. Maybe, some fuzzing can help here: generate random byte array, each byte decodes and operation on a specific component, check that no panic occurs.

  2. After Unify blobstor interfaces #1584, we can write test suite for the blobstor component interface and reuse it for testing fstree, blobovnicza trees and any future blobstor components.
@fyrchik fyrchik mentioned this issue Aug 19, 2022
Merged
@carpawell carpawell mentioned this issue Sep 14, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] shard: Open all components in case metabase has failed
d536a90 
All components must be opened first, before any other operation is
performed.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] local_object_storage: Add generic tests
65f9026 
Use them for writecache as a simple example.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] pilorama: Add generic tests
269fef3 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] metabase: Add generic tests
78dcbf1 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] blobstor: Add generic tests
5ffea67 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] blobovnicza: Remove IterateObjects
ada8a20 
It is used only once, makes sense to inline.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] blobstor: Add generic tests
0a37711 
This tests check that each blobstor component behaves similarly when
same methods are being used. It is intended to serve as a specification
for all future components.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] fstree: Return proper error for concurrent Delete
ecc10d8 
If the file doesn't exist, return `apistatus.ObjectNotFound`.
First check is still there as a shortcut.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] blobstor/*: Return ErrReadOnly for modifying operations
009b414 
This check should occur on the shard level, but because
blobstor components expose `Open(readOnly bool)` interface,
it is reasonable to expect an error here.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1686] blobstor/*: Remove unneeded tests
71c057b 
The blobovniczatree test also checks the amount of objects we can put,
so leave it here.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement generic tests for storage components fyrchik/neofs-node
1 participant
@fyrchik