Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle already registered NNS hashed correctly #1749

Closed
carpawell opened this issue Sep 2, 2022 · 1 comment · Fixed by #1752
Closed

Handle already registered NNS hashed correctly #1749

carpawell opened this issue Sep 2, 2022 · 1 comment · Fixed by #1752
Assignees
Labels
bug Something isn't working neofs-adm NeoFS Adm application issues U3 Regular

Comments

@carpawell
Copy link
Member

If contract hashes are not equal to the expected ones we just call AddRecord that seems like not expected action in our deploys but anyway.

if s == expectedHash {
return nil, nil
}
}
emit.AppCall(bw.BinWriter, nnsHash, "addRecord", callflag.All,
domain, int64(nns.TXT), expectedHash.StringLE())
if bw.Err != nil {
panic(bw.Err)
}
return bw.Bytes(), nil

@carpawell carpawell added bug Something isn't working neofs-adm NeoFS Adm application issues labels Sep 2, 2022
@alexchetaev alexchetaev added the U3 Regular label Sep 2, 2022
@fyrchik
Copy link
Contributor

fyrchik commented Sep 5, 2022

I think we can remove the logic of checking and just set the record. The checking was done to avoid spending more GAS than needed, but in on-prem installations this is not a problem. Also, the code should become much simpler.

@alexchetaev alexchetaev removed the 2022Q3 label Sep 5, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
In case we already have the record and it is invalid, we should
overwrite it instead of having several conflicting records.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
NNS proposal describes string N3 address format, however we must also
have hex-string for backwards compatibility.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-adm NeoFS Adm application issues U3 Regular
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants