Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command "control shards list" and prometheus metrics show different shard IDs #1863

Closed
anikeev-yadro opened this issue Oct 10, 2022 · 0 comments · Fixed by #1887
Closed

Command "control shards list" and prometheus metrics show different shard IDs #1863

anikeev-yadro opened this issue Oct 10, 2022 · 0 comments · Fixed by #1887
Assignees
@carpawell
Labels
bug Something isn't working U2 Seriously planned

Comments

@anikeev-yadro
Copy link

Expected Behavior

Command "control shards list" and prometheus metrics must show the same shard IDs

Current Behavior

Command "control shards list" and prometheus metrics show different shard IDs

Steps to Reproduce (for bugs)

  1. Get the shards list from neo-cli:
service@buky:~$ sudo neofs-cli --endpoint 127.0.0.1:8091 -w /etc/neofs/storage/wallet.json control shards list|grep Shard
Enter password >
Shard A7mUBz32qPFV2f2aSRsgw3:
Shard 6XncJAPvvrTszNkdmXymmb:
Shard PuS79dfLLYXGvUsBeWqtpf:
Shard QCG8AEWZjrDYBp4HaomUAS:

2.Get the shards statistics from prometeus metrics from the same node:

service@buky:~$ curl -s localhost:6672|grep neofs_node_object_counter
# HELP neofs_node_object_counter Objects counters per shards
# TYPE neofs_node_object_counter gauge
neofs_node_object_counter{shard="7Pu3szf61RBXQqiVtf69rB",type="logic"} 0
neofs_node_object_counter{shard="7Pu3szf61RBXQqiVtf69rB",type="phy"} 0
neofs_node_object_counter{shard="BbD7y8tXcXtqg8h57QVKkj",type="logic"} 4
neofs_node_object_counter{shard="BbD7y8tXcXtqg8h57QVKkj",type="phy"} 4
neofs_node_object_counter{shard="ESsMbvsTBDnZt6F61kCnxJ",type="logic"} 1
neofs_node_object_counter{shard="ESsMbvsTBDnZt6F61kCnxJ",type="phy"} 1
neofs_node_object_counter{shard="JGScYjYWUqS8Nm8Q2uqYVn",type="logic"} 0
neofs_node_object_counter{shard="JGScYjYWUqS8Nm8Q2uqYVn",type="phy"} 0

Logs: shars_id_bug.zip
Versions:

NeoFS Storage node
Version: v0.32.0-73-g01ddb3f8
GoVersion: go1.18.4

Your Environment

Server setup and configuration:
cloud, 4 VMs, 4 SN, 4 http qw, 4 s3 gw

Operating System and version (uname -a):
linux vedi 5.10.0-16-amd64 #1 SMP Debian 5.10.127-1 (2022-06-30) x86_64 GNU/Linux
@carpawell carpawell mentioned this issue Oct 12, 2022
Merged
carpawell added a commit that referenced this issue Oct 13, 2022
@carpawell
[#1863] node: Fix shard id in the object counter metrics
31c6236 
If shard ID is stored in metabase (it is not the first time boot), read it,
set it, use it (not a generated one) in the metrics writer.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@carpawell @aprasolova
[nspcc-dev#1863] node: Fix shard id in the object counter metrics
e268b39 
If shard ID is stored in metabase (it is not the first time boot), read it,
set it, use it (not a generated one) in the metrics writer.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
bug Something isn't working U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/Shard id in the object counter metrics
4 participants
@fyrchik @carpawell @alexchetaev @anikeev-yadro