Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate new private key silently if it is necessary in neofs-cli #2123

Closed
acid-ant opened this issue Dec 1, 2022 · 1 comment · Fixed by #2136
Closed

Generate new private key silently if it is necessary in neofs-cli #2123

acid-ant opened this issue Dec 1, 2022 · 1 comment · Fixed by #2136
Assignees
@cthulhu-rider
Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues
Milestone
v0.37.0

Comments

@acid-ant
Copy link
Contributor

acid-ant commented Dec 1, 2022

Avoid user from providing option -g, leave only -w.
@fyrchik
Copy link
Contributor

fyrchik commented Dec 1, 2022

Let's add verbose output about which key is used to sign the request.

@cthulhu-rider cthulhu-rider self-assigned this Dec 6, 2022
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Dec 6, 2022
[nspcc-dev#2123] cli: Mark --generate-key flag as deprecated
404b11e 
Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing or incorrect. It doesn't really matter to have such behavior
since if command can be executed w/o a wallet, user shouldn't be obliged
to add `-g` flag.

Mark `-g` flag as deprecated. Make `key.GetOrGenerate` function to
generate random private key if wallet path is omitted.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
@cthulhu-rider cthulhu-rider mentioned this issue Dec 6, 2022
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Dec 8, 2022
[nspcc-dev#2123] cli: Generate private key automatically in supported…
767970d 
… commands

Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Dec 8, 2022
[nspcc-dev#2123] cli: Generate private key automatically in supported…
906357e 
… commands

Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Dec 8, 2022
[nspcc-dev#2123] cli: Generate private key automatically in supported…
bd544bd 
… commands

Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue Dec 21, 2022
[nspcc-dev#2123] cli: Generate private key automatically in supported…
77428c8 
… commands

Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
@roman-khimov roman-khimov added this to the v0.36.0 milestone Mar 16, 2023
@roman-khimov roman-khimov modified the milestones: v0.36.0, v0.37.0 Apr 7, 2023
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 22, 2023
@cthulhu-rider
cli: Generate private key automatically in supported commands
4289f8c 
Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Closes nspcc-dev#2123.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue May 24, 2023
@cthulhu-rider
cli: Generate private key automatically in supported commands
186f915 
Some NeoFS CLI commands support anonymous execution. In previous
implementation command generated random private key if given wallet was
missing/incorrect and `--generate-key` (`-g`) flag was provided. It
doesn't really matter to have such behavior since if command can be
executed w/o a wallet, user shouldn't be obliged to add `-g` flag.

Make `key.GetOrGenerate` function to generate random private key if
wallet path is omitted.

Closes nspcc-dev#2123.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov added a commit that referenced this issue May 24, 2023
@roman-khimov
cli: Autogenerate random key even without -g flag where possible (#…
a37a340 
…2136)

* closes #2123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging a pull request may close this issue.

cli: Autogenerate random key even without -g flag where possible cthulhu-rider/neofs-node
4 participants
@fyrchik @roman-khimov @cthulhu-rider @acid-ant