Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neofs-adm should take network settings into account during contract update #2191

Closed
roman-khimov opened this issue Dec 30, 2022 · 0 comments
Closed

neofs-adm should take network settings into account during contract update #2191

roman-khimov opened this issue Dec 30, 2022 · 0 comments
Labels
neofs-adm NeoFS Adm application issues
Milestone
v0.36.0

Comments

@roman-khimov
Copy link
Member

roman-khimov commented Dec 30, 2022 •
edited
Loading

Expected Behavior

neofs-adm morph update-contracts taking wallets/contracts/RPC parameters and doing its job.

Current Behavior

On netmap contract upgrade any network settings are overwritten with some default ones unless they're given as a part of environment/config.

Possible Solution

If we're upgrading we already have some network and it already has some parameters, so the tool should just take (via RPC) and use them, except for parameters that are new and where default values are to be used.

Steps to Reproduce (for bugs)

  1. neofs-adm morph update-contracts --alphabet-wallets ... --contracts ... -r

Context

Mainnet upgrade.

Your Environment

v0.34.0
@roman-khimov roman-khimov added triage neofs-adm NeoFS Adm application issues labels Dec 30, 2022
roman-khimov added a commit that referenced this issue Apr 7, 2023
@roman-khimov
adm: use network settings on upgrade, fix #2191
c0c5132 
Not the most elegant piece of code, but it works for now, reducing potential
for operator errors.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added this to the v0.36.0 milestone Apr 11, 2023
roman-khimov added a commit that referenced this issue Apr 11, 2023
@roman-khimov
adm: use network settings on upgrade, fix #2191 (#2297)
8be0dcb 
Not the most elegant piece of code, but it works for now, reducing
potential for operator errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
neofs-adm NeoFS Adm application issues
Projects
None yet
Milestone
v0.36.0
Development

No branches or pull requests
1 participant
@roman-khimov