Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from using deprecated WS subscription APIs #2219

Closed
roman-khimov opened this issue Jan 26, 2023 · 1 comment
Closed

Move from using deprecated WS subscription APIs #2219

roman-khimov opened this issue Jan 26, 2023 · 1 comment
Assignees
@roman-khimov
Milestone
v0.36.1

Comments

@roman-khimov
Copy link
Member

Expected Behavior

NeoFS shouldn't use deprecated NeoGo APIs.

Current Behavior

pkg/morph/client/multi.go:82:12                                     staticcheck  SA1019: c.client.Notifications is deprecated: please, use custom channels with ReceiveBlocks, ReceiveTransactions, ReceiveExecutionNotifications, ReceiveExecutions, ReceiveNotaryRequests methods to subscribe for notifications. This field will be removed in future versions. 
pkg/morph/client/notary.go:426:15                                   staticcheck  SA1019: c.client.SignAndPushP2PNotaryRequest is deprecated: please use Actor from the notary subpackage. This method will be deleted in future versions. 
pkg/morph/client/notary.go:520:20                                   staticcheck  SA1019: c.client.CalculateNotaryFee is deprecated: NeoGo calculatenetworkfee method handles notary fees as well since 0.99.3, so this method is just no longer needed and will be removed in future versions. 
pkg/morph/client/notary.go:539:15                                   staticcheck  SA1019: c.client.SignAndPushP2PNotaryRequest is deprecated: please use Actor from the notary subpackage. This method will be deleted in future versions. 
pkg/morph/client/notifications.go:39:13                             staticcheck  SA1019: c.client.SubscribeForExecutionNotifications is deprecated: please, use ReceiveExecutionNotifications. This method will be removed in future versions. 
pkg/morph/client/notifications.go:67:12                             staticcheck  SA1019: c.client.SubscribeForNewBlocks is deprecated: please, use ReceiveBlocks. This method will be removed in future versions. 
pkg/morph/client/notifications.go:102:13                            staticcheck  SA1019: c.client.SubscribeForNotaryRequests is deprecated: please, use ReceiveNotaryRequests. This method will be removed in future versions. 
pkg/morph/client/notifications.go:216:12                            staticcheck  SA1019: cli.SubscribeForNewBlocks is deprecated: please, use ReceiveBlocks. This method will be removed in future versions. 
pkg/morph/client/notifications.go:229:13                            staticcheck  SA1019: cli.SubscribeForExecutionNotifications is deprecated: please, use ReceiveExecutionNotifications. This method will be removed in future versions. 
pkg/morph/client/notifications.go:245:14                            staticcheck  SA1019: cli.SubscribeForNotaryRequests is deprecated: please, use ReceiveNotaryRequests. This method will be removed in future versions.

Possible Solution

Use new APIs.
@roman-khimov roman-khimov added this to the v0.36.0 milestone Jan 26, 2023
@roman-khimov roman-khimov mentioned this issue Jan 26, 2023
Closed
masterSplinter01 added a commit to masterSplinter01/neofs-node that referenced this issue Feb 11, 2023
@masterSplinter01
[nspcc-dev#2219] Update neo-go version up to v0.101.0
383d486 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
masterSplinter01 added a commit to masterSplinter01/neofs-node that referenced this issue Feb 12, 2023
@masterSplinter01
[nspcc-dev#2219] Update neo-go version up to v0.101.0
c0d6247 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
masterSplinter01 added a commit to masterSplinter01/neofs-node that referenced this issue Feb 13, 2023
@masterSplinter01
[nspcc-dev#2219] Update neo-go version up to v0.101.0
1dafdb0 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
masterSplinter01 added a commit to masterSplinter01/neofs-node that referenced this issue Feb 13, 2023
@masterSplinter01
[nspcc-dev#2219] Update neo-go version up to v0.101.0
32cb106 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
masterSplinter01 added a commit to masterSplinter01/neofs-node that referenced this issue Mar 31, 2023
@masterSplinter01
[nspcc-dev#2219] Update subscriptions
073d1b5 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
Signed-off-by: Kira <kira@nspcc.ru>
@roman-khimov roman-khimov modified the milestones: v0.36.0, v0.37.0, v0.36.1 Apr 11, 2023
roman-khimov added a commit that referenced this issue Apr 19, 2023
@roman-khimov
morph: rework subscriptions
cc5820c 
This is a temporary scheme, just enough to almost get rid of "deprecated"
warnings (refs. #2219). It also fixes #2304.

See also #2306, #2307 and #1337.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Apr 19, 2023
Merged
roman-khimov added a commit that referenced this issue Apr 19, 2023
@roman-khimov
morph: rework subscriptions
50dd5c2 
This is a temporary scheme, just enough to almost get rid of "deprecated"
warnings (refs. #2219). It also fixes #2304.

See also #2306, #2307 and #1337.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Apr 20, 2023
@roman-khimov
(almost) Stop using deprecated subscription NeoGo APIs (#2308)
9831353 
Part of #2219, fixes #2304. Enough for 0.36.1 and we have a set of
related tasks to do for 0.37.0.
@roman-khimov
Copy link
Member Author

Fixed by #2310 and #2308 with one caveat left for #2309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roman-khimov roman-khimov

Labels
None yet
Projects
None yet
Milestone
v0.36.1
Development

No branches or pull requests
2 participants
@roman-khimov @masterSplinter01