Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Could not make notary deposit" on storage node #2263

Closed
roman-khimov opened this issue Feb 17, 2023 · 0 comments
Closed

"Could not make notary deposit" on storage node #2263

roman-khimov opened this issue Feb 17, 2023 · 0 comments
Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular

Comments

@roman-khimov
Copy link
Member

Expected Behavior

Notary deposits should be OK.

Current Behavior

Feb 17 13:43:42 node3 neofs-node[9352]: 2023-02-17T13:43:42.289Z        error        neofs-node/netmap.go:216        could not make notary deposit        {"error": "can't make notary deposit: script failed (FAULT state) due to an error: at instruction 114 (ASSERT): ASSERT failed"}

Looks very much like #2230 to me.

Steps to Reproduce (for bugs)

Unknown.

Context

Testnet.

I know we kinda have "endless" notary deposits now, but still there is something wrong here and most likely it's not notary-specific.

Your Environment

NeoFS Storage node
Version: v0.34.0 
GoVersion: go1.17.13
@roman-khimov roman-khimov added bug Something isn't working triage neofs-storage Storage node application issues labels Feb 17, 2023
@alexchetaev alexchetaev added the U3 Regular label Feb 17, 2023
roman-khimov added a commit to roman-khimov/neofs-node that referenced this issue Feb 17, 2023
@roman-khimov
morph/client: add CalledByEntry into the "grouped" scope
3692388 
Fixes nspcc-dev#2230, fixes nspcc-dev#2263. CustomGroups are nice while we're only calling NeoFS
contracts, but it doesn't work at all for standard ones like GAS or Notary.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit to roman-khimov/neofs-node that referenced this issue Feb 17, 2023
@roman-khimov
morph/client: recreate actor/wrappers in SetGroupSignerScope
d79d723 
That's the reason nspcc-dev#2230 and nspcc-dev#2263 were not detected earlier, we actually had
Global scope being used before reconnection to RPC node.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Feb 21, 2023
Closed
roman-khimov added a commit to roman-khimov/neofs-node that referenced this issue Feb 22, 2023
@roman-khimov
morph/client: add CalledByEntry into the "grouped" scope
85696c9 
Fixes nspcc-dev#2230, fixes nspcc-dev#2263. CustomGroups are nice while we're only calling NeoFS
contracts, but it doesn't work at all for standard ones like GAS or Notary.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit to roman-khimov/neofs-node that referenced this issue Feb 22, 2023
@roman-khimov
morph/client: recreate actor/wrappers in SetGroupSignerScope
6d04092 
That's the reason nspcc-dev#2230 and nspcc-dev#2263 were not detected earlier, we actually had
Global scope being used before reconnection to RPC node.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit to roman-khimov/neofs-node that referenced this issue Feb 22, 2023
@roman-khimov
morph/client: recreate actor/wrappers in SetGroupSignerScope
4c4e33c 
That's the reason nspcc-dev#2230 and nspcc-dev#2263 were not detected earlier, we actually had
Global scope being used before reconnection to RPC node.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @alexchetaev