Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check SN availability when approving it for a netmap #2475

Closed
roman-khimov opened this issue Aug 7, 2023 · 2 comments
Closed

Check SN availability when approving it for a netmap #2475

roman-khimov opened this issue Aug 7, 2023 · 2 comments
Assignees
@carpawell
Labels
enhancement Improving existing functionality neofs-ir Inner Ring node application issues
Milestone
v0.38.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I see new nodes on the map, but they're not responding to any queries (port closed/firewalled/whatever, but the node is unreachable).

Describe the solution you'd like

Check availability of the node before approving it.
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-ir Inner Ring node application issues labels Aug 7, 2023
@roman-khimov roman-khimov added this to the v0.38.0 milestone Aug 7, 2023
@cthulhu-rider
Copy link
Contributor

EndpointInfo could be good for this:

  • node should be online to respond
  • we'll may use response to make some sanity checks in the future

any other ideas?

@roman-khimov
Copy link
Member Author

Makes sense. It can be checked against node data we have in the request.

carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 1, 2023
@carpawell
ir: Check that just bootstrapped SN is available
8f93a19 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 1, 2023
@carpawell
ir: Check that just bootstrapped SN is available
2bea24e 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 1, 2023
@carpawell
ir: Check that just bootstrapped SN is available
7fa4a5a 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 4, 2023
@carpawell
ir: Check that just bootstrapped SN is available
acb6354 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 4, 2023
@carpawell
ir: Check that just bootstrapped SN is available
30fba81 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 5, 2023
@carpawell
ir: Check that just bootstrapped SN is available
b2e5c32 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 5, 2023
@carpawell
ir: Check that just bootstrapped SN is available
85ca87e 
Closes nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Sep 8, 2023
@carpawell
ir: Fix announced address reading for the client creation
9012d5f 
Do not pass raw multi-address to client, use URI instead.
Refs nspcc-dev#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-dev-env that referenced this issue Sep 8, 2023
@carpawell
ir: Add s04 self-signed SSL cert
33b6785 
It allows s04 availability check by the IR after the nspcc-dev/neofs-node#2475.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality neofs-ir Inner Ring node application issues
Projects
None yet
Milestone
v0.38.0
Development

No branches or pull requests
3 participants
@roman-khimov @carpawell @cthulhu-rider