Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capacity attribute in testnet config #602

Closed
alexvanin opened this issue Jun 9, 2021 · 3 comments · Fixed by #2495
Closed

Capacity attribute in testnet config #602

alexvanin opened this issue Jun 9, 2021 · 3 comments · Fixed by #2495
Assignees
@carpawell
Labels
enhancement Improving existing functionality neofs-storage Storage node application issues
Milestone
v0.38.0

Comments

@alexvanin
Copy link
Contributor

Testnet config ignores capacity attribute right now, so everyone has the same zero capacity and it does not affect placement function. However in the main network this is gonna be different. Do we need to provide some capacity value in testnet? How do we motivate user to set realistic available capacity value in config?

/cc @realloc @anatoly-bogatyrev
@alexvanin
Copy link
Contributor Author

@fyrchik can look at Proof-of-Storage papers, maybe we can afford to make single capacity proof at the node bootstrap.

@alexvanin
Copy link
Contributor Author

For the PoC we need to run some sort of Proof-Of-Storage algorithm at the bootstrap stage. Then provide the results at bootstrap operation. Then Alphabet nodes verify the result and set confirmed capacity attribute.

@roman-khimov
Copy link
Member

It shouldn't be configured, the node can get this data automatically (just look at statfs for shards). It can be overridden by the config at the same time. We can't prove this for now, but I believe it's more useful to have this data unverified than not have it all (node will reject data on overflow anyway).

Refs. nspcc-dev/neofs-sdk-go#438, it should be fixed in the same release with update to RC10.

@roman-khimov roman-khimov added this to the v0.39.0 milestone Jul 25, 2023
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-storage Storage node application issues and removed discussion Open discussion of some problem triage labels Jul 25, 2023
@roman-khimov roman-khimov mentioned this issue Jul 25, 2023
Closed
@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.38.0 Aug 4, 2023
@carpawell carpawell self-assigned this Aug 7, 2023
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 10, 2023
@carpawell
node: Announce capacity via the attributes
224961c 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Aug 10, 2023
Merged
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 10, 2023
@carpawell
node: Announce capacity via the attributes
99fd661 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 14, 2023
@carpawell
node: Announce capacity via the attributes
9ec51a1 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 14, 2023
@carpawell
node: Announce capacity via the attributes
bf32f1d 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 14, 2023
@carpawell
node: Announce capacity via the attributes
3eda9ed 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 15, 2023
@carpawell
node: Announce capacity via the attributes
15abfb6 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 15, 2023
@carpawell
node: Announce capacity via the attributes
7c54307 
It is done automatically (as a sum of existing space on every file system
available on the configured shards) but can be overwritten if `Capacity`
attribute is provided via the application configuration.
Closes nspcc-dev#602.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
roman-khimov added a commit that referenced this issue Aug 15, 2023
@roman-khimov
feat/Announce capacity via the attributes (#2495)
8a37926 
It is done automatically (as a sum of existing space on every file
system available on the configured shards) but can be overwritten if
`Capacity` attribute is provided via the application configuration.
Closes #602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality neofs-storage Storage node application issues
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

feat/Announce capacity via the attributes carpawell/neofs-node
4 participants
@realloc @alexvanin @roman-khimov @carpawell