Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofs-adm: retrieve storage wallet passwords from config #1539

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jun 23, 2022

The only question is whether it is more convenient to store passwords in the credentials section.
Decided to add a separate section not to overload the credentials section.

Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru

…nfig

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1539 (22f3c14) into master (b67974a) will decrease coverage by 0.01%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
- Coverage   35.76%   35.75%   -0.02%     
==========================================
  Files         308      308              
  Lines       18278    18288      +10     
==========================================
+ Hits         6537     6538       +1     
- Misses      11191    11200       +9     
  Partials      550      550              
Impacted Files Coverage Δ
cmd/neofs-adm/internal/modules/config/config.go 30.00% <0.00%> (-2.31%) ⬇️
cmd/neofs-adm/internal/modules/morph/generate.go 40.70% <0.00%> (-1.50%) ⬇️
cmd/neofs-adm/internal/modules/morph/root.go 50.40% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67974a...22f3c14. Read the comment docs.

@fyrchik fyrchik merged commit 451343c into nspcc-dev:master Jun 24, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
…nfig

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neofs-adm NeoFS Adm application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants